SOLR-16458: Add node threads JAX-RS API - #4722
Open
Yashgoswami-ds wants to merge 2 commits into
Open
Conversation
epugh
reviewed
Aug 9, 2026
epugh
reviewed
Aug 9, 2026
| } | ||
|
|
||
| @Override | ||
| public Boolean registerV2() { |
Contributor
There was a problem hiding this comment.
i am not totally positive, so need to look at other exampels, but maybe this registerV2 goes away, since this sithe v1 way? i thought the registerV2 was basically a way you could have a v1 api particpiate in the old v2 way... not posivite
Contributor
Author
There was a problem hiding this comment.
I’ll check the existing JAX-RS API implementations and verify whether registerV2() is still required here. I’ll update this accordingly.
Contributor
Author
|
@epugh
The updates are pushed in the latest commit. |
Contributor
Author
|
Hey, can someone check this out and tell me if I need to change anything or not ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a JAX-RS API for retrieving thread dump information from the receiving Solr node.
The existing
ThreadDumpHandlerfunctionality is exposed through the new JAX-RS endpoint while preserving the existing thread dump response structure and information.Changes
NodeThreadsApiendpoint for/node/threads.NodeThreadsResponsemodel for the JAX-RS response.ThreadDumpHandlerto expose the JAX-RS API.Testing
:solr:core:compileJava— passed:solr:core:test --tests org.apache.solr.handler.admin.ThreadDumpHandlerTest— passed (4 tests, 2 skipped)Issue
SOLR-16458